feat: Dynamic hooks for END_PRINT and START_PRINT macros #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjonuschat
force-pushed
the
feature/custom-end-print-hooks
branch
from
a1cec62 to
fb4a502
Compare
mjonuschat
changed the title
mjonuschat
force-pushed
the
feature/custom-end-print-hooks
branch
2 times, most recently
from
2cd394d to
32b6b7b
Compare
Implement a similar approach to START_PRINT to enable users to hook into the END_PRINT macro. This approach is more dynamic in that it allowes to call any Gcode Macro that starts with `_END_PRINT_ACTION_` and verifies that the desired action exists before calling it.
Revamp the current logic to hook into the START_PRINT macro and implement the same dynamic approach as END_PRINT for Gcode macros starting with `_START_PRINT_ACTION`, again verifying existence before calling the macro.
mjonuschat
force-pushed
the
feature/custom-end-print-hooks
branch
from
32b6b7b to
d25823b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a variation of the startprint_actions for end_print that looks for custom actions/modules that start with
_END_PRINT_ACTION_for the END_PRINT macro and modernize the START_PRINT macro to utilize the same approach for modules prefixed with_START_PRINT_ACTION.The legacy _MODULE_CUSTOM1 etc modules have been left in place to not break existing installations.