Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filament retract and unretract user variables for use in base and helper macros #642

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

tehniemer
Copy link
Contributor

Add user configurable variable for filament retract in end and cancel print macros.

Add user configurable variable for filament retract in end and cancel print macros.
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@tehniemer
Copy link
Contributor Author

I think this is still a valid addition.

@Frix-x
Copy link
Owner

Frix-x commented Jan 6, 2025

Thanks for the PR!

I want to merge this. But as stated in #658 this need to be linked to the loading during a purge at the beginning of a print. Indeed, what you retract at the end of a print should be inserted again at the beginning of the next one (at least it was designed like that).

And this can be probably linked to #645 and #641 at the same time.

Can you please complete the PR with this additional need?

Added unretract to prime line
@wight554
Copy link

wight554 commented Jan 6, 2025

In my testing I noticed that it's better to push a little bit more than retracted, like 10-20% more
I retract 30 and push 35, otherwise half of my purge line is somewhat empty. However would be better if anyone else shares their experience

@tehniemer
Copy link
Contributor Author

I just added an unretract to the prime line macro equal to the retract in the cancel and end print macros. Please let me know if that's good enough or if you would like an additional user variable for the extra push as mentioned by @wight554

@Frix-x
Copy link
Owner

Frix-x commented Jan 6, 2025

Yes, that's right, I think having a percentage factor combined to this could be a good idea.
Like by default 15% more: it doesn't cost much to do this and should be pretty harmless.

Added the same retract variable to the purge sequence and a separate unretract to the prime line sequence
@tehniemer
Copy link
Contributor Author

OK, I've added #641 and #645 into this one and created a second variable for the nozzle prime.

@tehniemer tehniemer changed the title Make filament retract user configurable in base macros Add filament retract and unretract user variables for use in base and helper macros Jan 7, 2025
@wight554
Copy link

wight554 commented Jan 7, 2025

The way I see it is letting user set unretract extra length similarly to slicer. Feels better UX wise. Not very critical though

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are near a merge. Just a few changes on my side, but nothing very problematic :)

macros/helpers/nozzle_cleaning.cfg Outdated Show resolved Hide resolved
user_templates/variables.cfg Outdated Show resolved Hide resolved
tehniemer and others added 2 commits January 7, 2025 12:36
Co-authored-by: Félix Boisselier <accounts@fboisselier.fr>
Co-authored-by: Félix Boisselier <accounts@fboisselier.fr>
@tehniemer
Copy link
Contributor Author

I'm good with both of those.

@Frix-x
Copy link
Owner

Frix-x commented Jan 8, 2025

Ok I'm good with it now and will merge! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants