-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filament retract and unretract user variables for use in base and helper macros #642
Conversation
Add user configurable variable for filament retract in end and cancel print macros.
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
I think this is still a valid addition. |
Thanks for the PR! I want to merge this. But as stated in #658 this need to be linked to the loading during a purge at the beginning of a print. Indeed, what you retract at the end of a print should be inserted again at the beginning of the next one (at least it was designed like that). And this can be probably linked to #645 and #641 at the same time. Can you please complete the PR with this additional need? |
Added unretract to prime line
In my testing I noticed that it's better to push a little bit more than retracted, like 10-20% more |
I just added an unretract to the prime line macro equal to the retract in the cancel and end print macros. Please let me know if that's good enough or if you would like an additional user variable for the extra push as mentioned by @wight554 |
Yes, that's right, I think having a percentage factor combined to this could be a good idea. |
Added the same retract variable to the purge sequence and a separate unretract to the prime line sequence
The way I see it is letting user set unretract extra length similarly to slicer. Feels better UX wise. Not very critical though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are near a merge. Just a few changes on my side, but nothing very problematic :)
Co-authored-by: Félix Boisselier <accounts@fboisselier.fr>
Co-authored-by: Félix Boisselier <accounts@fboisselier.fr>
I'm good with both of those. |
Ok I'm good with it now and will merge! Thank you :) |
Add user configurable variable for filament retract in end and cancel print macros.