Create adxl345_sht_v2.x.cfg #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SHT36_v2 differs from the SHT36_v1 and has the ADXL345 on SPI2, not SPI1.
|
Hey, thanks for the PR! It's ok for me like this as I do plan to work on the ADXL a little bit in the future to harmonize everything. So I'll integrate it like that for now :) |
Frix-x
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHT36_v2 differs from the SHT36_v1 and has the ADXL345 on SPI2, not SPI1. The Mellow docs are pretty confusing on this!
I'm not sure if this is the right way to go about it, or whether you would prefer to inherit the adxl345_sht.cfg and just override spi_bus?