fix status LEDs for separate nozzle and logo LEDs #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my Voron v0.2, with logo LEDs connected to the main MCU and nozzle LEDs connected to toolhead MCU. |
Frix-x
requested changes
Nov 1, 2023
|
Hey, thanks for the PR, it's a great patch! I'll merge it after you fix the typo :) |
The macro aways uses TRANSMIT=0 for the logo LEDs, which assumes that the subsequent call to nozzle LEDs will flush the data. That will only work if both sets of LEDs are on the same chain. The chains can be different though - configured through `status_leds_nozzle_led_name` and `status_leds_logo_led_name`. With this change, separate logo LEDs will use TRANSMIT=1 instead.
|
Very nice! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro aways uses TRANSMIT=0 for the logo LEDs, which assumes that the subsequent call to nozzle LEDs will flush the data. That will only work if both sets of LEDs are on the same chain.
The chains can be different though - configured through
status_leds_nozzle_led_nameandstatus_leds_logo_led_name. With this change, separate logo LEDs will use TRANSMIT=1 instead.