Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automated testing #134

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

Laikulo
Copy link
Contributor

@Laikulo Laikulo commented Jun 27, 2024

Adds linting with ruff and klippy's import test and test harness with a simple config.

Summary by Sourcery

This pull request introduces automated testing via a new GitHub Actions workflow. It includes linting with Ruff, Klippy's import test, and a test harness with a simple configuration for running smoke tests.

  • CI:
    • Added a GitHub Actions workflow for smoke tests, including linting with Ruff and Klippy's import test.
    • Configured matrix strategy for testing with multiple Klipper repositories.
    • Set up steps for checking out repositories, installing dependencies, building Klipper, and running tests.
  • Tests:
    • Introduced a test harness with a simple configuration for Klippy tests.

Copy link
Contributor

sourcery-ai bot commented Jun 27, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Laikulo - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@Laikulo Laikulo force-pushed the feature/ci_smoke_test branch from ad2823e to e856ec5 Compare June 27, 2024 00:23
@Laikulo
Copy link
Contributor Author

Laikulo commented Jun 27, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed the commit e856ec5 in this pull request.

@Frix-x
Copy link
Owner

Frix-x commented Jun 27, 2024

Hello,

Thank you very much for this PR ! It's actually something that I wanted to start working on (Klipper tests and also adding a bit of unit testing into S&T). That's a very good starting point!

I'll merge it :)

@Frix-x Frix-x merged commit f87713e into Frix-x:develop Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants