Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null connection proxy #162

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix null connection proxy #162

merged 1 commit into from
Jan 5, 2021

Conversation

jacobx1
Copy link
Contributor

@jacobx1 jacobx1 commented Nov 10, 2020

Restores ability for non-DI plugins to init by defaulting to the StreamDeckProxy if no implementation is passed to Initialize.

Originally handled here:

streamDeckProxy ?? new StreamDeckProxy());

Removed in 4bba9ea


Perhaps I misunderstand how this newer version of the Toolkit is supposed to be used. Will only DI be supported? In that case, this PR is of no use.

I hit this issue of _proxy being null when trying SamplePlugin to debug the issue that led me to #161

Restores ability for non-DI plugins to init by defaulting to the
StreamDeckProxy if no implementation is passed to Initialize.
@csharpfritz
Copy link
Collaborator

Good catch, and we do want to support folks that program with any style or architecture choice

@csharpfritz csharpfritz merged commit 75ecdf7 into FritzAndFriends:dev Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants