Adds New Reload Sound Effects for Magazine-Fed Bolt-Action Rifles and Updates Existing Gun Sound Lists #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fle fire sound effects.
|
I'll merge the PR but for future reference short action like reload or fire should have short sound that last less than a second, a 3 second long sound is going to feel weird in game since the reload happens instantly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds four new sound effects and their associated JSON to cover reloads for bolt-action rifles that feed from detachable box magazines; single-shot and fixed-magazine rifles have been omitted. All sound effects have been recorded and edited by myself, utilising an IG1889 Schmidt Ruben rifle. Had I possessed snap-caps, I would have also covered single-shot bolt-action rifles in this PR, but 7.5x55mm Swiss dummy cartridges are eye-bleadingly expensive, so... there’s something to acquire for Christmas, I suppose.
In addition, I have taken the liberty to update the sound lists for pocket pistols, tube-fed shotguns, and gunfire sounds for automatic rifles to take into account guns added and removed since my last PRs.
One fine day, a sound-pack-supported build of the game will arrive that can be used by blind folks, but, considering that that day hasn’t arrived just yet, these sound files have been untested within actual game settings.