Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace code preview in debug screen #375

Merged

Conversation

sebasbit
Copy link
Contributor

Due to a change in the output of the highlight_file function in PHP 8.3, when working with debugging enabled, the code preview is not displayed.

Screenshot 2024-08-12 000559

This PR aims to work with both 8.3 and <8.3 output, here some quick test. Before, the function used <br /> :

<code><span style...>
<span>code</span><br /><span>code</span><br /><span>code</span>
</span>
</code>

Now it uses break lines:

<pre><code style...>
  <span>code</span>
  <span>code</span>
  <span>code</span>
</code></pre>

@thePanz thePanz force-pushed the fix-stack-trace-code-preview branch from 1689c82 to ef5607d Compare February 14, 2025 16:09
@thePanz thePanz self-requested a review February 14, 2025 16:10
@thePanz
Copy link
Member

thePanz commented Feb 14, 2025

Tested on a PHP v8.3 setup, and it fixes the issue!

Muchas gracias @sebasbit !

@thePanz thePanz merged commit caf01e2 into FriendsOfSymfony1:master Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants