Fixed validation for Request parameter that is an array without default value

[eugef]

If Request parameter is an array without default value and parameter is not set - then an error should be thrown that "parameter value is not an array".

Steps to reproduce:

• Create a Request parameter with the following config

@RequestParam(name="clients", array=true)

• In a post request do not send this parameter at all

Actual result (before the fix):

• 'clients' parameter is set to an empty array

Expected result (with the fix):

• Error "Request parameter value of 'clients' is not an array"

If empty array should be a default value if parameter is not set, then 'strict' should be set to false, example:

@RequestParam(name="clients", array=true, strict=false)

[lsmith77]

can you add a failing test case?

[eugef]

@lsmith77, do you want me to add test case that would fail before this fix is applied?

[lsmith77]

you can do it in this PR .. or even better as a separate PR.

1. PR with the failing test case
2. update this PR to include the test case plus your fix

[eugef]

Ok, will do it

[lsmith77]

ping

[eugef]

Sorry, was too busy this weekend.

[eugef]

Test is added, also separate PR with only failing test is created #915

[lsmith77]

hmm it seems like the commit in this PR doesn't match the on in #915 ..

[eugef]

Well, i cherry-picked commit ec90c29 from 'patch-1' branch into the 'patch-1-test-only'
Or should i did in other way?

[lsmith77]

hmm not sure why the commit hash is different then .. anyway .. looks good in manual inspection .. thanks!

[eugef]

Ups, seems i had deleted by accident one test case eugef@ec90c29#diff-fbad238da345246612fd46bb2c0323c8L373

What is the best way to add it back? Create another PR?

[lsmith77]

yeah .. another PR .. thx

[eugef]

Done #916, please merge

[lsmith77]

@eugef can you have a look at #960 ?