-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception handler move to a service #802
Exception handler move to a service #802
Conversation
Renaming the config and the service is a BC break. and I don't understand the reason of this change. the exception handler is already a service |
Yes BC Break I know. For now I have no idea to avoid it. It is already a service but you can only change the class name or I miss something. |
yes, I fear you will need to add some BC code to ensure that the old and the new settings still work, throwing an exception in the extension if both are used at the same time. also the tests need to be fixed/expanded accordingly |
I will do. |
please also rebase on master so that the travis setup works again. |
👍 I already had the need to inject stuff on the exception handler |
someone just needs to wrap up the last details |
I hope I have time this week |
ping @tyx ? |
ping |
closing in favor of #942 |
Let people more easily override the exception handler.