Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handler move to a service #802

Closed

Conversation

tyx
Copy link
Contributor

@tyx tyx commented Jul 1, 2014

Let people more easily override the exception handler.

@stof
Copy link
Member

stof commented Jul 1, 2014

Renaming the config and the service is a BC break.

and I don't understand the reason of this change. the exception handler is already a service

@tyx
Copy link
Contributor Author

tyx commented Jul 1, 2014

Yes BC Break I know. For now I have no idea to avoid it.

It is already a service but you can only change the class name or I miss something.
So it is not really a service as the view_handler which can be totally overrided by users.

@lsmith77
Copy link
Member

lsmith77 commented Jul 2, 2014

yes, I fear you will need to add some BC code to ensure that the old and the new settings still work, throwing an exception in the extension if both are used at the same time. also the tests need to be fixed/expanded accordingly

@tyx
Copy link
Contributor Author

tyx commented Jul 2, 2014

I will do.

@lsmith77
Copy link
Member

lsmith77 commented Jul 4, 2014

please also rebase on master so that the travis setup works again.

@eduardosoliv
Copy link
Contributor

👍 I already had the need to inject stuff on the exception handler

@lsmith77
Copy link
Member

someone just needs to wrap up the last details

@tyx
Copy link
Contributor Author

tyx commented Jul 15, 2014

I hope I have time this week

@ghost
Copy link

ghost commented Aug 4, 2014

ping @tyx ?

@lsmith77
Copy link
Member

@jrobeson you could also fork his branch and submit a new PR with @tyx's and you additional commits if you have time to wrap this up

@lsmith77
Copy link
Member

ping

@lsmith77 lsmith77 added this to the 1.5.0 milestone Nov 19, 2014
@lsmith77
Copy link
Member

closing in favor of #942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants