Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native PHP8 Route attributes #2325

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Aug 17, 2021

Closes #2293

@W0rma W0rma force-pushed the route-attributes branch from 4833ef8 to 6f39ad0 Compare August 17, 2021 05:44
@W0rma W0rma marked this pull request as ready for review August 17, 2021 05:47
@W0rma W0rma force-pushed the route-attributes branch from 6f39ad0 to c3284bf Compare August 17, 2021 10:55
@W0rma W0rma force-pushed the route-attributes branch from c3284bf to a00028e Compare August 17, 2021 10:57
@GuilhemN GuilhemN merged commit 5fed474 into FriendsOfSymfony:3.x Aug 18, 2021
@GuilhemN
Copy link
Member

Awesome, thank you @W0rma!

@W0rma W0rma deleted the route-attributes branch August 30, 2021 12:30
*
* @Rest\View()
*/
#[Rest\Get(path: '/{page}', name: 'product_list', requirements: ['page' => '\d+'], defaults: ['_format' => 'json'])]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! can you update de documentation please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect annotation type-hinging
3 participants