-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility of Route annotations with symfony >= 5.3 #2312
Fix compatibility of Route annotations with symfony >= 5.3 #2312
Conversation
80df5be
to
d5ae9ce
Compare
Can this be merged? it creates a lot of deprecation warnings in SF 5.3 |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Ready for merge for me 👍🏻
Adding support for PHP8 attributes in Route annotations should be quite simple after this PR got merged. @xabbuh Would you prefer a separate PR for adding attributes support or should I add it to this PR? |
please create an additional PR for that |
Hello @W0rma ! I made a similar implementation on a fork and if you want to keep the full compatibility of old annotations from <5.2 you need to add this. |
d5ae9ce
to
2cf8dd7
Compare
@Th3Mouk Thank you for the hint regarding compatibility with symfony 6. My approach is a bit different since I want to enable native PHP 8 attributes afterwards. Nevertheless I now added an additional check which should ensure compatibility with symfony 6. |
Thank you @W0rma! |
Constructing Route annotations using named arguments was added in symfony 5.2 (symfony/symfony#40266)
Closes #2311