Support dot notation for resources in symfony flex #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled this PR and it solved my issues with the loader, i do now have a ServiceNotFoundException
But I do not think its related to this pull request, but more of a new issue with the private services by default, is anybody working on that currently? |
|
@juliusstoerrle Feel free to propose a PR. |
|
Can this please be merged! |
|
Thank you @tomaszhanc. |
xabbuh
added a commit
that referenced
this pull request
Nov 24, 2017
…zhanc)
This PR was merged into the 2.2-dev branch.
Discussion
----------
Support dot notation for resources in symfony flex
Symfony Flex introduced a new notation for routes resources:
```
controllers:
resource: "../src/Controller"
```
The current implementation of `DirecotryRouteLoader` supports only @ notation to locate a resource by file locator. That PR fix it for Symfony Flex notation.
Commits
-------
ba79b41 Support dot notation for resources in symfony flex
xabbuh
added a commit
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony Flex introduced a new notation for routes resources:
The current implementation of
DirecotryRouteLoadersupports only @ notation to locate a resource by file locator. That PR fix it for Symfony Flex notation.