Don't get repository at construction time, it could be not loaded yet! #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some more researches, I discovered that could be my installation fault. I'll leave this PR open, since it could be good to remove that call from constructor! |
stof
reviewed
Apr 26, 2018
Entity/TokenManager.php
Outdated
| * @param $name | ||
| * @return mixed | ||
| */ | ||
| public function __get($name) |
There was a problem hiding this comment.
should not be public to provide BC with a protected property.
and it should trigger a deprecation warning
There was a problem hiding this comment.
__get can only be public... I can't think a method to provide retrocompatibility for private property.
Entity/TokenManager.php
Outdated
| return $this->getRepository(); | ||
| } | ||
|
|
||
| return $this->$name; |
There was a problem hiding this comment.
should not allow access. This gives public access to private properties
|
👍 for me, phpstan is broken however. |
|
Note: this also applies to other repositories, not just EntityRepositories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when trying to load some repositories through compiler pass.
At Doctrine\Bundle\DoctrineBundle\Repository\ContainerRepositoryFactory->getRepository(), it tried to load repository of my User Entity.
I changed the TokenManager, so it doesn't try to get it too soon!