return early

Frequinzy · Mar 15, 2024 · cd77b05 · cd77b05
1 parent 1d4415b
commit cd77b05
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/main/java/org/jabref/logic/bibtex/comparator/BibDatabaseDiff.java b/src/main/java/org/jabref/logic/bibtex/comparator/BibDatabaseDiff.java
@@ -49,6 +49,11 @@ private static EntryComparator getEntryComparator() {
     private static List<BibEntryDiff> compareEntries(List<BibEntry> originalEntries, List<BibEntry> newEntries, BibDatabaseMode mode) {
         List<BibEntryDiff> differences = new ArrayList<>();
 
+        // Prevent IndexOutOfBoundException
+        if (newEntries.isEmpty()) {
+            return differences;
+        }
+
         // Create a HashSet where we can put references to entries in the new
         // database that we have matched. This is to avoid matching them twice.
         Set<Integer> used = new HashSet<>(newEntries.size());
@@ -88,11 +93,6 @@ private static List<BibEntryDiff> compareEntries(List<BibEntry> originalEntries,
                     }
                 }
             }
-
-            // Prevent IndexOutOfBoundException
-            if (newEntries.isEmpty()) {
-                return differences;
-            }
             BibEntry bestEntry = newEntries.get(bestMatchIndex);
             if (bestMatch > MATCH_THRESHOLD
                     || hasEqualCitationKey(originalEntry, bestEntry)