Fix PHP 8.2 deprecation warning #759
Open
+42
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieleAlessandra
force-pushed
the
feature/daniele/fix-deprecation-warning-with-php8.2
branch
from
2724729 to
452e982
Compare
fajardoleo
reviewed
Nov 27, 2024
includes/entities/class-fs-user.php
Outdated
| * Should clean up the serialized data to avoid PHP 8.2 warning on next execution. | ||
| */ | ||
| public function __wakeup() { | ||
| if ( isset($this->is_beta) ) { |
There was a problem hiding this comment.
@DanieleAlessandra What if is_beta is null?
fajardoleo
reviewed
Nov 27, 2024
includes/entities/class-fs-user.php
Outdated
| @@ -48,6 +48,19 @@ function __construct( $user = false ) { | |||
| parent::__construct( $user ); | |||
| } | |||
|
|
|||
| /** | |||
| * @return void | |||
There was a problem hiding this comment.
@DanieleAlessandra I think this should be after the description.
fajardoleo
reviewed
Nov 27, 2024
includes/entities/class-fs-user.php
Outdated
| * This function removes the deprecated 'is_beta' property from the serialized data. | ||
| * Should clean up the serialized data to avoid PHP 8.2 warning on next execution. | ||
| */ | ||
| public function __wakeup() { |
There was a problem hiding this comment.
@DanieleAlessandra When the method is public, there's no need to include public.
fajardoleo
reviewed
Nov 27, 2024
includes/entities/class-fs-user.php
Outdated
| /** | ||
| * @return void | ||
| * | ||
| * This function removes the deprecated 'is_beta' property from the serialized data. |
There was a problem hiding this comment.
@DanieleAlessandra Please use "method" instead of "function".
fajardoleo
reviewed
Nov 27, 2024
includes/entities/class-fs-site.php
Outdated
| class FS_Site extends FS_Scope_Entity { | ||
| /** | ||
| * @var number | ||
| */ | ||
| public $site_id; | ||
| /** | ||
| * @var number |
There was a problem hiding this comment.
@DanieleAlessandra This should be int like in the get_unfiltered_site_url() method (also consistent with the annotation you removed). For entity IDs though, we use number (like in the FS_Entity class).
DanieleAlessandra
force-pushed
the
feature/daniele/fix-deprecation-warning-with-php8.2
branch
2 times, most recently
from
64b9641 to
93d2d11
Compare
|
This PR needs to be removed, cannot merge directly to master |
[menu] [menu-url] Fixed an issue with the menu URL generation logic.
DanieleAlessandra
force-pushed
the
feature/daniele/fix-deprecation-warning-with-php8.2
branch
2 times, most recently
from
88730e2 to
f8429f2
Compare
…ion warning adding missing property to FS_Site class and using magic functions in FS_User class. FS_Plugin_Plan has been fixed in June. [User Entity] Removed magic method __unserialize for backward compatibility with PHP 7.3 and older Removing FS_User::$is_beta dynamic created property with obsolete data from database
DanieleAlessandra
force-pushed
the
feature/daniele/fix-deprecation-warning-with-php8.2
branch
from
f8429f2 to
cfa06e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report on PHP 8.2 deprecation warnings for dynamic properties highlighted three cases, which this PR addresses:
unserialize.Changes:
@property FS_Pricing[] $pricingannotation fromFS_Plugin_Plan, as the property now exists and the annotation is no longer necessary.$blog_idproperty toFS_Siteand removed the corresponding annotation, similar to the previous class.__wakeupmagic method toFS_Userto remove deprecated properties from serialized entities.Added the__unserializemagic method toFS_Userto manage the result ofunserializeand prevent warnings. This method only works with public properties and can be removed if the__wakeupmethod is sufficient.__unserializemagic method is detected as non-magic in PHP 7.3 and older byphpcs.