Fix ft-share-button when the window width is below 900
#6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening modal causes focus change, so if you close modal on focus out, it won't open modal
github-actions
bot
added
the
PR: waiting for review
MarmadileManteater
requested review from
PikachuEXE,
absidue and
ChunkyProgrammer
absidue
approved these changes
Dec 31, 2024
kommunarr
approved these changes
Dec 31, 2024
ChunkyProgrammer
approved these changes
Dec 31, 2024
github-actions
bot
removed
the
PR: waiting for review
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Opening modal causes focus change, so if you close modal on focus out, it won't open modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
ft-share-buttonwhen the window width is below900Pull Request Type
Description
The
ft-share-buttondoesn't show its prompt properly when the window width is below900. ThehandleDropdownFocusOutfunction is called when the prompt is shown causing it to immediately hide. The result is that it seems like the ft-share-button doesn't work on mobile. This PR addresses this by adding a check to thehandleDropdownFocusOutfunction to not hide the dropdown ifuseModalistrue.Screenshots
Testing
900