Add --help and --new-window flag and fix --version flag

[Zander671]

Add --help and --new-window flag and fix --version flag

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

#4446

Description

This contains three commits. The first adds a --new-window argument. This argument causes a new window to be opened in an existing instance. If there is no existing instance, it creates a new instance. The second fixes the --version flag that got broken by #2606. The third adds a --help flag.

Screenshots

Testing

The --help and --version flags were (hopefully) trivial to test. Their output can be seen above. The scope of the modifications required for the --new-window flag is also fairly small. I tested starting freetube both with and without the --new-window flag and both with and without a url. It worked in all four cases.

Desktop

• OS: ArchLinux
• OS Version: 6.12.4-zen1-1-zen
• FreeTube version: v0.22.1

Additional context

[kommunarr]

This is working great for me!

suggestion (non-blocking): A non-recognized argument error might be a good idea for preventing an accidental app load from a typo if we don't mind slightly expanding the scope. It could be frustrating to type -version and accidentally launch a window. E.g., Here's a similar error from nano for reference:

nano: unrecognized option '--potato'
Type 'nano -h' for a list of available options.

[Zander671]

The problem (at least on Linux) with validating arguments in this way is that Electron parses arguments like --enable-features=UseOzonePlatform and --ozone-platform=wayland. While it would be possible to check against a list of all Electron's supported flags, this seems like it might be hard to maintain as new flags are added (unless there is a way to get all supported arguments programmatically, but a quick search yielded no results).

[kommunarr]

Ah, I completely forgot about that. Here's how Codium handles this for a more similar example, where they show a warning but still continue to launch. Will approve now, as I'm not sure of not a fan of the effort to get this list of known options:

Warning: 'potato' is not in the list of known options, but still passed to Electron/Chromium.

[absidue]

I haven't got around to testing this yet, but at least from the code it looks like --version and --help will only be usable if FreeTube is not currently running.

[Zander671]

I haven't got around to testing this yet, but at least from the code it looks like --version and --help will only be usable if FreeTube is not currently running.

FreeTube calls app.requestSingleInstanceLock() and checks the return value in runApp(). The --help and --version flags are checked before runApp() ever gets called. This seems to work fine in my testing.