Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text colour in player overflow menu #6213

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Fix text colour in player overflow menu #6213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@
color: var(--side-nav-hover-text-color) !important;
}

:deep(.shaka-current-selection-span) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@absidue This also affects the color of the stats button text, which can render it nearly invisible depending on your theme.
Screen Shot 2024-12-09 at 11 28 20 am

How about:

:deep(.shaka-overflow-menu-only .shaka-current-selection-span) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OothecaPickle could you open up an issue for this so this doesnt get lost

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OothecaPickle could you open up an issue for this so this doesnt get lost

#6406

color: var(--tertiary-text-color) !important;
}

/* End of theming code */

.sixteenByNine {
Expand Down