Fix seek bar thumbnail overflowing when exiting full screen #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
previously approved these changes
Oct 24, 2024
kommunarr
reviewed
Oct 24, 2024
|
Fullscreen is fixed
This isnt |
PikachuEXE
previously approved these changes
Oct 24, 2024
absidue
dismissed stale reviews from PikachuEXE and ChunkyProgrammer
via
f598392
absidue
force-pushed
the
thumbnail-overflow
branch
from
5cbaed2 to
f598392
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 25, 2024
kommunarr
approved these changes
Oct 25, 2024
ChunkyProgrammer
approved these changes
Oct 25, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix seek bar thumbnail overflowing when exiting full screen
Pull Request Type
Related issue
Description
This pull request fixes the thumbnail container causing the UI to overflow after exiting full screen if the user was hovering over the end of the seek bar. This happens because full screen is usually much larger than the size of the window outside of full screen, so the position of the seek bar thumbnail goes from being inside the viewport to outside of it, which results in a horizontal scroll bar showing up to compensate for it overflowing.
Screenshots
See linked thread for a video demonstrating the bug
Testing
Desktop