Handle IP blocks better on the watch page #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
As our team cant didnt ran into the IP blocks maybe create test build and provide it to the users of that issue? |
absidue
force-pushed
the
watch-page-ip-block-message
branch
from
db4f430 to
caa37d8
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 4, 2024
ChunkyProgrammer
approved these changes
Oct 4, 2024
PikachuEXE
approved these changes
Oct 4, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle IP blocks better on the watch page
Pull Request Type
Related issue
closes #5534
Description
This pull request fixes the
TypeError: Cannot read properties of null (reading 'reason')error message by correcting where we get thereasonproperty from and by adding a proper error message when the users is IP blocked.This changes in this pull request are based on the response files provided in this comment #5534 (comment), as I haven't found an IP address that is blocked and nobody responded to this comment asking for information on how to find a blocked IP #5534 (comment)
Testing
I have not been able to test this, as I haven't found an IP address that is blocked and nobody responded to this comment asking for information on how to find a blocked IP #5534 (comment)
Desktop