Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for copying hashtag links #5538

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Add support for copying hashtag links #5538

merged 1 commit into from
Aug 12, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Aug 7, 2024

Add support for copying hashtag links

Pull Request Type

  • Feature Implementation

Description

When you right-click on an in-app video, playlist or channel link we display context menu entries to copy the YouTube or Invidious version of that link. At the moment those buttons aren't displayed for in-app hashtag links, which are added by this pull request.

Screenshots

Before:
before

After:
after

Testing

  1. Search for a hashtag e.g #asmr
  2. Right click on the hashtag icon or text
  3. You should see two new context menu entries Copy YouTube Link and Copy Invidious Link
  4. Test that they both work correctly (e.g. by pasting into a text editor after you've clicked it to check the URL)

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.21.3

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 7, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 7, 2024 21:41
@FreeTubeBot FreeTubeBot merged commit 69b1011 into FreeTubeApp:development Aug 12, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 12, 2024
@absidue absidue deleted the copy-hashtag branch August 12, 2024 20:58
@Gorrrg Gorrrg mentioned this pull request Jan 30, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot