Avoid cloning all profiles when subscribing and unsubscribing #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
PR: low priority
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 18, 2024
PikachuEXE
approved these changes
Jun 19, 2024
kommunarr
approved these changes
Jun 19, 2024
| showToast(this.$t('Channel.Channel has been removed from your subscriptions')) | ||
|
|
||
| if (profile._id === MAIN_PROFILE_ID && profileIds.length > 1) { | ||
| showToast(this.$t('Channel.Removed subscription from {count} other channel(s)', { |
There was a problem hiding this comment.
suggestion (non-blocking, minor): Can do as a separate PR, as this is a pre-existing "issue", but we might as well pluralize the label instead of doing (s)
| const profile = state.profileList.find(profile => profile._id === id) | ||
|
|
||
| // use filter instead of splice in case the subscription appears multiple times | ||
| // https://github.com/FreeTubeApp/FreeTube/pull/3468#discussion_r1179290877 |
There was a problem hiding this comment.
question (non-blocking, minor): Doesn't have to be considered for this PR, but wouldn't a user know that they're subscribed to a channel multiple times? That + the amount of time since this bug has been fixed (unsure exactly when) means maybe this is safe to make a splice now.
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 20, 2024
* development: (120 commits) Update version number to v0.21.0 Remove limited donation methods (FreeTubeApp#5290) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Avoid cloning all profiles when subscribing and unsubscribing (FreeTubeApp#5289) Fix arrow keys not working in the Create New Playlist prompt (FreeTubeApp#5243) Bump ws from 8.16.0 to 8.17.1 (FreeTubeApp#5291) Remove a few bits of unused code (FreeTubeApp#5287) Update About page to display correct Freetube logo based on currently set theme (FreeTubeApp#5126) Translated using Weblate (Croatian) * Update playlist page titles (FreeTubeApp#5271) Update Invidious instances list (FreeTubeApp#5288) Translated using Weblate (Polish) Bump the eslint group with 2 updates (FreeTubeApp#5275) Bump marked from 12.0.2 to 13.0.0 (FreeTubeApp#5276) Bump sass from 1.77.4 to 1.77.5 (FreeTubeApp#5277) Bump lefthook from 1.6.15 to 1.6.16 (FreeTubeApp#5279) Bump webpack from 5.91.0 to 5.92.0 (FreeTubeApp#5278) Update Flatpak PR Workflow to work with updated module (FreeTubeApp#5270) Translated using Weblate (Portuguese) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jun 20, 2024
* development: (102 commits) Update version number to v0.21.0 Remove limited donation methods (FreeTubeApp#5290) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese (Portugal)) Avoid cloning all profiles when subscribing and unsubscribing (FreeTubeApp#5289) Fix arrow keys not working in the Create New Playlist prompt (FreeTubeApp#5243) Bump ws from 8.16.0 to 8.17.1 (FreeTubeApp#5291) Remove a few bits of unused code (FreeTubeApp#5287) Update About page to display correct Freetube logo based on currently set theme (FreeTubeApp#5126) Translated using Weblate (Croatian) * Update playlist page titles (FreeTubeApp#5271) Update Invidious instances list (FreeTubeApp#5288) Translated using Weblate (Polish) Bump the eslint group with 2 updates (FreeTubeApp#5275) Bump marked from 12.0.2 to 13.0.0 (FreeTubeApp#5276) Bump sass from 1.77.4 to 1.77.5 (FreeTubeApp#5277) Bump lefthook from 1.6.15 to 1.6.16 (FreeTubeApp#5279) Bump webpack from 5.91.0 to 5.92.0 (FreeTubeApp#5278) Update Flatpak PR Workflow to work with updated module (FreeTubeApp#5270) Translated using Weblate (Portuguese) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid cloning all profiles when subscribing and unsubscribing
Pull Request Type
Description
Here is a summary of the main improvements:
Testing
Subscribe to and unsubscribe from channels in invididual profiles as well as the "All Channels" one. Additionally make sure that the changes are correctly synced between windows.
Desktop