Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split view count and published date into two lines on small displays #4736

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Split view count and published date into two lines on small displays #4736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b0dfdc
Split view count and published date into two lines on small displays
MarmadileManteater Mar 2, 2024
4960ec4
Add blank line
MarmadileManteater Mar 3, 2024
b8f3503
Add blank line back
MarmadileManteater Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 34 additions & 20 deletions src/renderer/components/watch-video-info/watch-video-info.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,29 +72,43 @@
color: var(--tertiary-text-color);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mistakenly removed it, but it should be back now

.likeSection {
color: var(--tertiary-text-color);
display: flex;
flex-direction: column;
margin-inline-start: auto;
margin-block-start: 4px;
max-inline-size: 210px;
text-align: end;
color: var(--tertiary-text-color);
display: flex;
flex-direction: column;
margin-inline-start: auto;
margin-block-start: 4px;
max-inline-size: 210px;
text-align: end;

@media screen and (max-width: 680px) {
margin-inline-start: 0;
text-align: start;
}
@media screen and (max-width: 680px) {
margin-inline-start: 0;
text-align: start;
}

.likeBar {
border-radius: 4px;
block-size: 8px;
margin-block-end: 4px;
.likeBar {
border-radius: 4px;
block-size: 8px;
margin-block-end: 4px;
}

.likeCount {
margin-inline-end: 0;
display: flex;
gap: 3px;
}
}
.datePublishedAndViewCount {
@media only screen and (max-width: 460px) {
display: flex;
justify-content: left;
flex-direction: column;

.likeCount {
margin-inline-end: 0;
display: flex;
gap: 3px;
.seperator {
display: none;
}
}
}
.videoViews {
white-space: nowrap;
}
}
}
6 changes: 4 additions & 2 deletions src/renderer/components/watch-video-info/watch-video-info.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
<div class="videoMetrics">
<div class="datePublishedAndViewCount">
{{ publishedString }} {{ dateString }}
<template v-if="!hideVideoViews">
• {{ parsedViewCount }}
<template
v-if="!hideVideoViews"
>
<span class="seperator">• </span><span class="videoViews">{{ parsedViewCount }}</span>
</template>
</div>
<div
Expand Down
Loading