Make video thumbnails have certain height before image loading starts to avoid layout shifts #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to avoid layout shifts
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
github-actions
bot
added
the
PR: waiting for review
absidue
reviewed
Feb 27, 2024
|
|
||
| .thumbnailImage.thumbnailLoading { | ||
| // Makes img element sized correctly before image loading starts | ||
| aspect-ratio: 16 / 9; |
There was a problem hiding this comment.
According to the aspect-ratio docs on MDN, you can do this for images, which will make it use 16/9 until the image is downloaded and after that use the image's aspect ratio.
That would allow you to remove the javascript and the thumbnail loading class.
Suggested change
| aspect-ratio: 16 / 9; | |
| aspect-ratio: 16/9 auto; |
absidue
approved these changes
Feb 28, 2024
ChunkyProgrammer
approved these changes
Feb 28, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 1, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 4, 2024
* development: (29 commits) Translated using Weblate (Chinese (Traditional)) Fix URL copied via right click menu (FreeTubeApp#4690) Translated using Weblate (Croatian) Wrap ft-icon buttons below before they go fully vertical (FreeTubeApp#4735) * Make activating a chapter selector makes window scroll to top like clicking on timestamp links (FreeTubeApp#4722) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Make video thumbnails have certain height before image loading starts to avoid layout shifts (FreeTubeApp#4723) Update subscription cache when visiting a channel (FreeTubeApp#4667) Fix fallback to Invidious for the podcasts channel tab (FreeTubeApp#4731) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Arabic) Translated using Weblate (Polish) Translated using Weblate (Dutch) Translated using Weblate (Icelandic) Translated using Weblate (Spanish) Translated using Weblate (Arabic) Translated using Weblate (Icelandic) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified)) ...
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 7, 2024
* development: (161 commits) Add video search in user playlist feature (FreeTubeApp#4622) Add discussion info when opening an issue (FreeTubeApp#4676) Translated using Weblate (Lithuanian) Translated using Weblate (Serbian) Translated using Weblate (Estonian) Bump mini-css-extract-plugin from 2.8.0 to 2.8.1 (FreeTubeApp#4742) Bump electron from 28.2.3 to 29.1.0 (FreeTubeApp#4743) Bump lefthook from 1.6.1 to 1.6.4 (FreeTubeApp#4740) Bump the babel group with 2 updates (FreeTubeApp#4739) Bump swiper from 11.0.6 to 11.0.7 (FreeTubeApp#4741) Bump electron-builder from 24.12.0 to 24.13.3 (FreeTubeApp#4744) Split view count and published date into two lines on small displays (FreeTubeApp#4736) Translated using Weblate (Chinese (Traditional)) Fix URL copied via right click menu (FreeTubeApp#4690) Translated using Weblate (Croatian) Wrap ft-icon buttons below before they go fully vertical (FreeTubeApp#4735) * Make activating a chapter selector makes window scroll to top like clicking on timestamp links (FreeTubeApp#4722) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Make video thumbnails have certain height before image loading starts to avoid layout shifts (FreeTubeApp#4723) ... # Conflicts: # src/renderer/views/Playlist/Playlist.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Similar to #4713
Description
As title
The constant aspect ratio is only applied before image loading finished (no idea how to detect image loading start) in case the image got different aspect ratio
Screenshots
Image loading not started yet
Image loaded started
Testing
Replace HTTP Cache(so that renderer does the image loading)Desktop
Additional context