Update places generating sharable YT video URLs to always return prefix https://youtu.be/ #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
commented
Jan 15, 2024
| @@ -188,11 +188,12 @@ export default defineComponent({ | |||
| }, | |||
|
|
|||
| youtubeShareUrl: function () { | |||
| const videoUrl = `https://youtu.be/${this.id}` | |||
There was a problem hiding this comment.
No logic change here just refactor
| @@ -127,11 +127,12 @@ export default defineComponent({ | |||
| if (this.isPlaylist) { | |||
| return this.youtubePlaylistUrl | |||
| } | |||
| const videoUrl = `https://youtu.be/${this.id}` | |||
There was a problem hiding this comment.
Actual logic change
4 tasks
absidue
previously approved these changes
Jan 15, 2024
|
Just fixed URL, I used |
absidue
approved these changes
Jan 17, 2024
kommunarr
approved these changes
Jan 22, 2024
ChunkyProgrammer
approved these changes
Jan 25, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
Can't really say it's a bug but it's better to return consistent values for sharable video URLs
Screenshots
Places that can copy sharable video URLs
Testing
Find (A) video with online playlist (B) video without online playlist
Ensure all places that can copy youtube URL will copy same working URLs
For places see screenshots
Desktop
Additional context