Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SponsorBlock: video id hash length to 4 #4313

Merged
merged 1 commit into from
Nov 9, 2023
Merged

SponsorBlock: video id hash length to 4 #4313

merged 1 commit into from
Nov 9, 2023

Conversation

animafps
Copy link
Contributor

@animafps animafps commented Nov 9, 2023

SponsorBlock: video id hash length to 4

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

n/a

Description

Use only 4 characters for the hash to improve privacy, see:
https://wiki.sponsor.ajay.app/w/API_Docs#GET_/api/skipSegments/:sha256HashPrefix

Screenshots

Testing

Desktop

  • OS:Linux
  • OS Version:6.5.7
  • FreeTube version:0.19.1

Additional context

allows support for https://github.com/TeamPiped/sponsorblock-mirror/

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 9, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 9, 2023 22:06
@FreeTubeBot FreeTubeBot merged commit 820264e into FreeTubeApp:development Nov 9, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 9, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 13, 2023
@PikachuEXE
Merge branch 'development' into feature/playlist-2023-05
2fbfa18 
* development: (24 commits)
  Translated using Weblate (Arabic)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (French)
  Translated using Weblate (Greek)
  Translated using Weblate (Russian)
  Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311)
  Translated using Weblate (Turkish)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Portuguese)
  Translated using Weblate (Croatian)
  video id hash length to 4 (FreeTubeApp#4313)
  Translated using Weblate (Spanish)
  Translated using Weblate (Serbian)
  Translated using Weblate (Czech)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Simplified))
  Add identifiers to channels hidden by ID (FreeTubeApp#4230)
  Translated using Weblate (Japanese)
  Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099)
  ...
kommunarr pushed a commit to PikachuEXE/FreeTube that referenced this pull request Nov 18, 2023
@animafps @kommunarr
video id hash length to 4 (FreeTubeApp#4313)
1bef889
kommunarr pushed a commit to PikachuEXE/FreeTube that referenced this pull request Nov 18, 2023
@PikachuEXE @kommunarr
Merge branch 'development' into feature/playlist-2023-05
ffe373a 
* development: (24 commits)
  Translated using Weblate (Arabic)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (French)
  Translated using Weblate (Greek)
  Translated using Weblate (Russian)
  Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311)
  Translated using Weblate (Turkish)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Portuguese)
  Translated using Weblate (Croatian)
  video id hash length to 4 (FreeTubeApp#4313)
  Translated using Weblate (Spanish)
  Translated using Weblate (Serbian)
  Translated using Weblate (Czech)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Simplified))
  Add identifiers to channels hidden by ID (FreeTubeApp#4230)
  Translated using Weblate (Japanese)
  Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099)
  ...
kommunarr pushed a commit to PikachuEXE/FreeTube that referenced this pull request Nov 18, 2023
@PikachuEXE @kommunarr
Merge branch 'development' into feature/playlist-2023-05
5e89bd6 
* development: (24 commits)
  Translated using Weblate (Arabic)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Polish)
  Translated using Weblate (French)
  Translated using Weblate (Greek)
  Translated using Weblate (Russian)
  Add missing Electron guards after FreeTubeApp#4230 (FreeTubeApp#4311)
  Translated using Weblate (Turkish)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Portuguese)
  Translated using Weblate (Croatian)
  video id hash length to 4 (FreeTubeApp#4313)
  Translated using Weblate (Spanish)
  Translated using Weblate (Serbian)
  Translated using Weblate (Czech)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Simplified))
  Add identifiers to channels hidden by ID (FreeTubeApp#4230)
  Translated using Weblate (Japanese)
  Fixed order of elements to allow for proper tabbing in comments section (FreeTubeApp#4099)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE Awaiting requested review from PikachuEXE

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@animafps @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot