Change babel plugin to use import map as source of truth #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
from
0946ff0
to
eff3499
Compare
FredKSchott
commented
Feb 5, 2020
| @@ -3,4 +3,4 @@ www/index.md | |||
| www/dist | |||
| /node_modules | |||
| /web_modules | |||
| __tests__/**/*/web_modules | |||
| __tests__/integration/*/web_modules | |||
There was a problem hiding this comment.
I also ended up doing some cleanup of the test files. We had some test-generated files being added in git. Sorry for the spam!
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
2 times, most recently
from
dbe9a8c
to
b06e6a5
Compare
FredKSchott
commented
Feb 5, 2020
| const explicitImportMap = path.join(process.cwd(), dir, explicitPath); | ||
| return fs.readFileSync(explicitImportMap, {encoding: 'utf8'}); | ||
| } | ||
| const localImportMap = path.join(process.cwd(), dir, `import-map.local.json`); |
There was a problem hiding this comment.
This part will make a lot more sense when the next PR comes out. Feel free to skip for now.
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
2 times, most recently
from
885bbef
to
7d5eb94
Compare
drwpow
approved these changes
Feb 5, 2020
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
from
7d5eb94
to
bcff8ca
Compare
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
from
bcff8ca
to
cc3852b
Compare
FredKSchott
force-pushed
the
babel-plugin-via-import-map
branch
from
ac5cf73
to
4f2b939
Compare
drwpow
added a commit
that referenced
this pull request
Jul 24, 2020
drwpow
added a commit
that referenced
this pull request
Jul 27, 2020
drwpow
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a duplication of logic/responsibility between Snowpack and the babel plugin that's been bothering me for a while. Both are responsible for converting package names to
web_modules/files:I've started a new project for Snowpack that will make it impossible to keep maintaining the logic in two places.
This PR makes it so that the babel plugin now just reads the info already contained inside the import map, and doesn't do any additional transformations on its own (besides
optionalExtensionsadding). This is now more rigid (will fail if it can't find the import map, can't find the package in the import map) but reading from a static map also means that everything is much less error prone, more deterministic, and probably a bit faster. You now know exactly where each import will be re-written to ahead of time.One interesting thing here is that we moved the 'addVersion' behavior from the plugin into Snowpack proper. All import-map users can now benefit from this logic as well, not just those using the plugin. For simplicity, I went with a file hash instead of the package version.