Skip to content
This repository has been archived by the owner on Dec 30, 2021. It is now read-only.

Update react-refresh plugin instructions to run on development only #147

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Jun 19, 2020

React Refresh only works on development and throws on any other environment.
It's currently making yarn build fail after following the README instructions.

Ref: facebook/react#15939

React Refresh only works on development and throws on any other environment.
It's currently making `yarn build` fail.
Ref: facebook/react#15939
@brunolemos brunolemos requested a review from a team as a code owner June 19, 2020 05:35
Copy link
Owner

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

IIRC the plugin used to only run in production, maybe with an internal NODE_ENV check. But I like this as more explicit, even if it is a little more verbose for some.

@FredKSchott FredKSchott merged commit bf84059 into FredKSchott:master Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants