Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with Tab Kit 2 #56

Closed
2 tasks done
fofajardo opened this issue Sep 10, 2018 · 2 comments
Closed
2 tasks done

Improve compatibility with Tab Kit 2 #56

fofajardo opened this issue Sep 10, 2018 · 2 comments
Assignees
@fofajardo
Labels
Add-on Compatibility App: Basilisk App: Pale Moon Component: Themes Priority: Medium Status: Done
Milestone
TGS 1.0.8

Comments

@fofajardo
Copy link
Member

fofajardo commented Sep 10, 2018 •
edited
Loading

As reported on the forum.

  • Pale Moon
  • Basilisk
@fofajardo fofajardo added this to the TGS 1.0.8 milestone Sep 10, 2018
@fofajardo fofajardo self-assigned this Sep 10, 2018
@fofajardo fofajardo changed the title Improve compatibility with TabKit2 Improve compatibility with Tab Kit 2 Sep 10, 2018
fofajardo added a commit that referenced this issue Dec 1, 2018
@fofajardo
Minor: Fix most layout issues with TabKit 2
1b4f9e7 
* Tag #56
* Separates fixes file into two: one for Pale Moon and Basilisk
* Also rearranges the chrome manifest file a bit
fofajardo added a commit that referenced this issue Dec 1, 2018
@fofajardo
Minor: Fix most layout issues with TabKit 2
11545dc 
* Tag #56
* Separates fixes file into two: one for Pale Moon and Basilisk
* Also rearranges the chrome manifest file a bit
* Increment ordinal group values to something higher to avoid overlaps
@fofajardo
Copy link
Member Author

TabKit 2 has a difference in behavior between its versions for Pale Moon (0.13.3) & Basilisk (0.12.17):

Basilisk:

  • Left edge tab bar - normal direction
  • Right edge tab bar - reverse direction

Pale Moon:

  • Left edge tab bar - reverse direction
  • Right edge tab bar - normal direction

@fofajardo
Copy link
Member Author

I've found out a few minutes ago that Tab Kit 2 (0.13.*) has incorrect labels:
capture

Versions lower than 0.13 are unaffected (< 0.12.*)

fofajardo referenced this issue Dec 3, 2018
@fofajardo
Minor: Remove TK2 0.12.* fixes, additional fix for TK2 0.13.*
6d09c05 
* Tag #52
* Cater to Tab Kit 2's incorrect tab bar edge label.
  - TK2 0.13.*'s label for left and right edges are switched.
  - Meaning left edge is the right edge and vice versa
  - TK2 0.12.* and below are unaffected and have the correct label.
* This was the main issue why I can't get to finish this bug. I just figured this whole thing out today...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fofajardo fofajardo

Labels
Add-on Compatibility App: Basilisk App: Pale Moon Component: Themes Priority: Medium Status: Done
Projects
None yet
Milestone
TGS 1.0.8
Development

No branches or pull requests
1 participant
@fofajardo