Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Signing with secp256k1 and secp256r1 #67

Closed
FrankC01 opened this issue Feb 1, 2023 · 3 comments
Closed

[change] Signing with secp256k1 and secp256r1 #67

FrankC01 opened this issue Feb 1, 2023 · 3 comments
Assignees
@FrankC01
Labels
bug Something isn't working change Modify existing code

Comments

@FrankC01
Copy link
Owner

FrankC01 commented Feb 1, 2023 •
edited
Loading

As per
MystenLabs/sui#7423
Changes to secp256/k/r1 signing includes dropping the recovery byte v
@FrankC01 FrankC01 added the change Modify existing code label Feb 1, 2023
@FrankC01 FrankC01 self-assigned this Feb 1, 2023
@FrankC01 FrankC01 mentioned this issue Feb 1, 2023
Closed
FrankC01 added a commit that referenced this issue Feb 9, 2023
@FrankC01
0.12.0 Release. Supporting SUI 0.25.0. Closes #71. References #67
a2b67bf
FrankC01 added a commit that referenced this issue Feb 13, 2023
@FrankC01
Closes #67. Added BCS (experimental)
20cc02b
@FrankC01
Copy link
Owner Author

A regression in pysui with SUI 0.26.0.
Using sui client new-address to generate an secp256r1 key works with all signing in pysui however; the pysui creation of same key type fails on signing.

@FrankC01 FrankC01 reopened this Feb 15, 2023
@FrankC01
Copy link
Owner Author

secp256r1 still failing intermittently on signing complaining that the s value must be small.

pysui is using a crypto library (ecdsa) that is conformant, however in debugging I see the s value is sometimes much larger than the acceptable range defined by MystenLabs.

Having conversations with MystenLabs on this issue.

@FrankC01 FrankC01 added the bug Something isn't working label Feb 23, 2023
@FrankC01 FrankC01 mentioned this issue Feb 23, 2023
Closed
@FrankC01
Copy link
Owner Author

Finally have this fixed in the next release of pysui (0.15.0) which will be posted along with sui 0.28.1 release... soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankC01 FrankC01

Labels
bug Something isn't working change Modify existing code
Projects
pysui
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrankC01