Replace non-Xbox location error prompt with flashing error icon #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlaminSarge
changed the title
|
@Fr33dan any concerns with this impl? should the error be moved to be more prominent around the non-Xbox location box? |
|
No seems fine. I think my github notifications have been going to spam and I've been using my work account day to day so I just didn't see it. |
Ahhh makes sense. I used to run into that until I just made an entire separate browser profile for work vs home. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When non-Xbox location has an error/is missing, instead of interrupting the app with a popup warning, this creates an error icon next to the "Select non-Xbox Location" button. The icon flashes for about 3 seconds whenever it gets a new error (if the error message remains the same as before it does not flash). Hovering over the icon shows the reason for the error (which was previously the text inside the popup box).
Tested setting and clearing the error with various games, it seems to work fine.
The only thing I can think of that would be a concern about this is potential accessibility issues for screen readers/tiny text.