Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Render class to draw the scene #33

Merged
merged 8 commits into from
Jun 4, 2024
Merged

feat: Render class to draw the scene #33

merged 8 commits into from
Jun 4, 2024

Conversation

mathieurobert1
Copy link
Collaborator

I created the Render class to display the scene.

More details : #30

@mathieurobert1 mathieurobert1 added the enhancement New feature or request label Jun 3, 2024
@mathieurobert1 mathieurobert1 self-assigned this Jun 3, 2024
@mathieurobert1 mathieurobert1 linked an issue Jun 3, 2024 that may be closed by this pull request
Implement the Render class - Zappy GUI #30
Closed
3 tasks
@mathieurobert1 mathieurobert1 requested a review from Njord201 June 3, 2024 12:19
theophile-jr
theophile-jr previously approved these changes Jun 3, 2024
View reviewed changes
Njord201
Njord201 previously approved these changes Jun 3, 2024
View reviewed changes
@mathieurobert1 mathieurobert1 dismissed stale reviews from Njord201 and theophile-jr via 1e8d672 June 3, 2024 12:29
Thomaltarix
Thomaltarix requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, but overall it's good

gui/src/Render/Render.cpp Outdated Show resolved Hide resolved
gui/src/Render/Render.cpp Outdated Show resolved Hide resolved
gui/src/Render/Render.cpp Show resolved Hide resolved
@Thomaltarix Thomaltarix mentioned this pull request Jun 3, 2024
Closed
7 tasks
theophile-jr
theophile-jr requested changes Jun 4, 2024
View reviewed changes
gui/src/Render/UserCamera.cpp Outdated Show resolved Hide resolved
@mathieurobert1 mathieurobert1 requested review from theophile-jr, AxelF44 and Njord201 and removed request for Njord201 June 4, 2024 08:40
Thomaltarix
Thomaltarix reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little question, but overall great

gui/include/Render/UserCamera.hpp Show resolved Hide resolved
Thomaltarix
Thomaltarix approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

@Thomaltarix Thomaltarix requested review from Njord201 and removed request for Njord201 June 4, 2024 10:56
@mathieurobert1 mathieurobert1 merged commit e38389b into main Jun 4, 2024
4 checks passed
@mathieurobert1 mathieurobert1 deleted the feat/implement-the-render-class branch June 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Njord201 Njord201 Njord201 approved these changes

@AxelF44 AxelF44 AxelF44 approved these changes

@Thomaltarix Thomaltarix Thomaltarix approved these changes

@theophile-jr theophile-jr theophile-jr approved these changes

Assignees

@mathieurobert1 mathieurobert1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Render class - Zappy GUI
5 participants
@mathieurobert1 @theophile-jr @Thomaltarix @AxelF44 @Njord201