Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/logic server gui zappy server #250

Merged
merged 13 commits into from
Jun 23, 2024
Merged

Upgrade/logic server gui zappy server #250

merged 13 commits into from
Jun 23, 2024

Conversation

AxelF44
Copy link
Collaborator

@AxelF44 AxelF44 commented Jun 22, 2024

I've upgrade the communication between GUI and Server !

@AxelF44 AxelF44 added the enhancement New feature or request label Jun 22, 2024
@AxelF44 AxelF44 self-assigned this Jun 22, 2024
@AxelF44 AxelF44 linked an issue Jun 22, 2024 that may be closed by this pull request
Upgrade logic SERVER - GUI - ZAPPY Server #231
Closed
@AxelF44 AxelF44 requested a review from Thomaltarix June 22, 2024 18:14
Thomaltarix
Thomaltarix previously approved these changes Jun 22, 2024
View reviewed changes
mathieurobert1
mathieurobert1 requested changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@mathieurobert1 mathieurobert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to made please.

gui/src/Engine/Engine.cpp Outdated Show resolved Hide resolved
gui/src/GUIUpdater/GUIUpdater.cpp Show resolved Hide resolved
Thomaltarix
Thomaltarix previously approved these changes Jun 22, 2024
View reviewed changes
mathieurobert1
mathieurobert1 requested changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@mathieurobert1 mathieurobert1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request for the bad explaination in my last request

gui/src/GUIUpdater/GUIUpdater.cpp Outdated Show resolved Hide resolved
Thomaltarix
Thomaltarix previously approved these changes Jun 22, 2024
View reviewed changes
Njord201
Njord201 requested changes Jun 22, 2024
View reviewed changes
server/include/gui/gui.h Outdated Show resolved Hide resolved
@AxelF44 AxelF44 requested review from Thomaltarix and Njord201 June 22, 2024 19:18
Thomaltarix
Thomaltarix approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe one day

@AxelF44 AxelF44 merged commit c155b0c into main Jun 23, 2024
4 checks passed
@AxelF44 AxelF44 deleted the upgrade/logic-server-gui-zappy-server branch June 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Njord201 Njord201 Njord201 approved these changes

@Thomaltarix Thomaltarix Thomaltarix approved these changes

@mathieurobert1 mathieurobert1 mathieurobert1 approved these changes

Assignees

@AxelF44 AxelF44

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade logic SERVER - GUI - ZAPPY Server
4 participants
@AxelF44 @mathieurobert1 @Thomaltarix @Njord201