Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/gui implement parsing for pbc pic pie and smg commands zappy gui #21

Conversation

mathieurobert1
Copy link
Collaborator

I added the following server commands to the parsing: smg, pic, pbc and pie.
Moreover I remove the hashtag from the parsing, now the '#player' is just 'player'.

More details : #15

@mathieurobert1 mathieurobert1 added enhancement New feature or request tests labels May 29, 2024
@mathieurobert1 mathieurobert1 self-assigned this May 29, 2024
@mathieurobert1 mathieurobert1 linked an issue May 29, 2024 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little thing to change

gui/include/Parsing/ServerParser.hpp Outdated Show resolved Hide resolved
gui/src/Parsing/ServerParser.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Thomaltarix Thomaltarix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mathieurobert1 mathieurobert1 merged commit 535d39b into main Jun 3, 2024
4 checks passed
@mathieurobert1 mathieurobert1 deleted the feat/gui-implement-parsing-for-pbc-pic-pie-and-smg-commands-zappy-gui branch June 3, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gui implement parsing for pbc, pic, pie and smg commands - Zappy GUI
3 participants