Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly exposed baseURL #150

Closed
kvnkim opened this issue Apr 4, 2024 · 3 comments
Closed

Publicly exposed baseURL #150

kvnkim opened this issue Apr 4, 2024 · 3 comments

Comments

@kvnkim
Copy link

kvnkim commented Apr 4, 2024

  • multi-scrobbler: [e.g. 0.7.0]

Additional context
Hello, thanks for this project it's working great as expected, however I was a tad concerned about the security of the web server being exposed (not on the default port of 9078)

I don't have the ability to configure a reverse proxy or http auth due to shared host restrictions on the vps (though I assume that would break webhooks altogether and the purpose of the whole thing), is it possible to have it not launch the web server and log only? i'm not too concerned atm, the only thing a person could do is restart the brainz client I have configured. Any suggestions?

@FoxxMD
Copy link
Owner

FoxxMD commented Apr 4, 2024

If you are running MS with the docker image then preventing access is as easy as not publishing the port when running the container (don't use -p in run command or comment out ports section in docker-compose.yml)

If you are running locally (with npm/node from the command line) I've added the ability to disable the web server in the develop branch/image:

  • ENV DISABLE_WEB=true
  • In All-in-One config (config.json) use the top-level property "disableWeb": true

If you do this correctly you'll see this in the log on startup

[2024-04-04 09:28:42.811 -0400] WARN   : [App] [API] API and Dashboard have been DISABLED. Note that any ingress sources (Plex, Jellyfin, Tautulli, etc...) will be unusable

@kvnkim kvnkim closed this as completed Apr 4, 2024
@kvnkim kvnkim reopened this Apr 4, 2024
@kvnkim
Copy link
Author

kvnkim commented Apr 4, 2024

Yeah, just as I thought it would break the webhooks/Tautulli as a source if the webserver was offline heh

@FoxxMD FoxxMD closed this as completed in 52b08ef Apr 11, 2024
@FoxxMD
Copy link
Owner

FoxxMD commented Apr 11, 2024

This feature is now available in v0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants