Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify examples/README #366

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Clarify examples/README #366

merged 1 commit into from
Sep 7, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Sep 7, 2024

I thought it was confusing that the directory is examples/ but the README says to navigate to examples/directory

I thought it was confusing that the directory is `examples/` but the README says to navigate to `examples/directory`
@navidcy navidcy self-requested a review September 7, 2024 21:08
Copy link
Member

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we should delete the .toml/readme.md from the examples directory all together and have clear instructions on how to run these in the docs

@navidcy navidcy merged commit 1dd98e4 into main Sep 7, 2024
5 checks passed
@navidcy navidcy deleted the glwagner-patch-1 branch September 7, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants