Fix potential energy calculation bug in MultiLayerQG.energies
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! I was thinking to add/modify a test to catch this. The tests at the moment have H=1 and thus were passing anyway? |
Right, I think that's what was happening. How's this? I tried writing a test with H = 10 to see if it works. |
|
@apaloczy bump a patch release in Project.toml to v0.14.1 |
|
Also perhaps I can combine the energy tests.ls it OK if I push in the pr? |
navidcy
changed the title
MultiLayerQG.energies
navidcy
approved these changes
Jul 7, 2022
|
I did it. Deleted the old test and just kept yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #292 by adding a missing
1/sum(params.H)factor to the potential energies inMultiLayerQG.energies.