Change client request failed logging to info for 404 responses

[cookenox]

No description provided.

[jepp3]

for readability it is maybe nicer to not use short hand and not have a negative path ( "resource.not.found " != message ) , making it easier to read.

Level logLevel = Level.INFO;
if(throwable instanceof WebException webException) {
	var status = webException.getStatus();
	var errorMessage = webException.getError();

	if(NOT_FOUND.equals(status) && "resource.not.found".equals(errorMessage)) {
	     logLevel = Level.WARN;
	}
}

LOG.atLevel(logLevel).log("Failed request. Url: {}", request, throwable);

But im not sure it is better. but you got my blessing :)

[cookenox]

I remember now that you prefer more verbose style :)

What do you mean by "short hand"?

Also how do you suggest that I avoid using not? Your suggestion won't work out of the box since WARN should be the default. I guess I could and a case assigning WARN again if it is "resource.not.found" but not sure that is cleaner?

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud