-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Icon Request Template #20275
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,60 @@ | ||
name: Icon request | ||
description: Suggest an icon to be included in Font Awesome | ||
description: Suggest an icon, modifier, or emoji to be included in Font Awesome | ||
labels: ["new icon"] | ||
title: "Icon request: " | ||
projects: ["FortAwesome/20"] | ||
title: "Icon Request: " | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thanks for taking the time to request a new icon! | ||
- type: textarea | ||
id: use-case | ||
attributes: | ||
label: Use case | ||
description: Describe how this icon could be used. | ||
- type: textarea | ||
id: example | ||
value: "## Before You Request" | ||
- type: markdown | ||
attributes: | ||
label: Example image | ||
description: Insert the example image here if necessary. A good example is a single color image which plays well at small sizes (16px) | ||
value: | | ||
Thanks for requesting a new Font Awesome icon! But first, let's get some specifics out of the way. For example, lots of amazing custom icons can already be created using our [Icon Wizard](https://blog.fontawesome.com/icon-wizard/)! Please check through this list first to ensure your request is as useful and unique as possible: | ||
- type: checkboxes | ||
id: icon-request-checklist | ||
id: checklist | ||
attributes: | ||
label: Icon request checklist | ||
label: Checklist | ||
options: | ||
- label: 'The title starts with "Icon request: " and is followed by the requested icon name' | ||
- label: 'The title of this issue starts with "Icon Request: " and is followed by the new icon name *(ex. "Icon Request: Proton Torpedo")*' | ||
required: true | ||
- label: 'This icon does not represent a brand' | ||
- label: This icon does not represent a brand | ||
required: true | ||
- label: 'This is a single icon or matched pair (Ex: `lock` / `unlock`)' | ||
- label: 'This request is for a single icon or a matched pair *(ex. `lock` and `unlock`)*' | ||
required: true | ||
- label: The request is for a concrete object, or I've included an example image | ||
- label: I've already [searched through existing issues](https://github.com/FortAwesome/Font-Awesome/issues), and to the best of my knowledge this request isn't a duplicate | ||
required: true | ||
- label: 'I have [searched for existing issues](https://github.com/FortAwesome/Font-Awesome/issues) and to the best of my knowledge this is not a duplicate' | ||
required: true | ||
- label: 'I have [understood how requests work](https://fontawesome.com/community/leaderboard/new#faqs)' | ||
- label: I understand [how new icon requests work](https://fontawesome.com/support#requesting-icons) | ||
required: true | ||
- type: markdown | ||
attributes: | ||
value: "## Your Request" | ||
- type: dropdown | ||
id: type | ||
attributes: | ||
label: Request type | ||
description: What kind of icon or element do you have in mind? | ||
options: | ||
- 😄 Emoji (please provide Unicode code point) | ||
- 🧙 Wizard modifier | ||
- ✨ New icon | ||
- 🔧 Icon improvement | ||
## - 🧱 Element (save this for the future) | ||
default: 0 | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: use-case | ||
attributes: | ||
label: Use case | ||
description: How should this new icon be used? | ||
placeholder: ex. a proton torpedo for our holographic space station attack plans | ||
validations: | ||
required: true | ||
- type: textarea | ||
id: example | ||
attributes: | ||
label: Visual example | ||
description: Insert an example image or other visual reference to help us get the picture (literally). | ||
validations: | ||
required: true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be our issue, even though it’s nearly identical to how the old version was handled. My guess is line 13 needs to be indented to nest under the Value key