Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross validation Spider / Aragog #309

Open
lsoucasse opened this issue Dec 11, 2024 · 6 comments
Open

Cross validation Spider / Aragog #309

lsoucasse opened this issue Dec 11, 2024 · 6 comments
Assignees
Labels
interior Physics - interior evolution JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 2: high Priority level 2: high time criticality or importance

Comments

@lsoucasse
Copy link
Member

We have now Aragog running, using look up table and producing reasonable output.

But we now need a comparison with Spider to validate the implementation, see first results from @planetmariana here.

@lsoucasse lsoucasse added the interior Physics - interior evolution label Dec 11, 2024
@lsoucasse lsoucasse added the Priority 2: high Priority level 2: high time criticality or importance label Dec 11, 2024
@planetmariana
Copy link
Contributor

Hi @timlichtenberg @lsoucasse @nichollsh,

I run the exact same simulation as here, but with interior model=SPIDER. With those conditions the planet reached the global energy balance. Besides the time-stepping factor mentioned #193, the rheological front when using Aragog starts above the CMB, so I'm a bit confused about it, as we are using the same melting curves, just in the P-T space. On the other side, both of them finish around the same time. We can discuss further about this, in the meantime I will check from the Aragog which parameter is causing the behaviour in the first 80 GPa.

plot_interior
plot_global_log

@timlichtenberg
Copy link
Collaborator

I copy the images from the Aragog run from #306 (comment) to here in this thread again.
image
image

It looks to me as if the Aragog simulation is not initialised on an adiabat. From 80 GPa downwards the temperature profile is isothermal already at the first timestep. We need to understand the reason for this, possibly the initialisation is not yet working correctly?

@timlichtenberg timlichtenberg moved this from Next up to In Progress in PROTEUS Development Roadmap Dec 13, 2024
@lsoucasse
Copy link
Member Author

Could you send us the corresponding Aragog input file @planetmariana ?

@planetmariana
Copy link
Contributor

@lsoucasse is the input file Aragog.toml in main, I just change the interior model as SPIDER or Aragog, using both with JANUS. Both simulations took around 12hr, so for now I'm checking from Aragog which parameter can be changed. As discussed before @timlichtenberg if I change rheological_transition_melt_fraction there's a difference, but I don't know how unphysical that can be. See below:

Output from Aragog with rheological_transition_melt_fraction=0.4 :
mixed_phase

Output from Aragog with rheological_transition_melt_fraction=0.2
rheological_0 2

@timlichtenberg
Copy link
Collaborator

0.4 is good and can stay. The latter is output from only running Aragog directly, and the former is using PROTEUS to execute Aragog, right? In the latter plot (just Aragog) the temperature profile looks adiabatic, it's only that the initial temperature is not high enough to generate a fully molten planet. This could mean that something is not properly communicated from PROTEUS to Aragog.

@planetmariana
Copy link
Contributor

Yes, these last ones are outputs directly from Aragog. Ok, I see the problem. I will check then outputs/inputs from both sides to see where's the difference.

@lsoucasse lsoucasse added the JOSS publication: PROTEUS TBD before PROTEUS JOSS publication label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interior Physics - interior evolution JOSS publication: PROTEUS TBD before PROTEUS JOSS publication Priority 2: high Priority level 2: high time criticality or importance
Projects
Status: In Progress
Development

No branches or pull requests

3 participants