This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
add NPM 5 support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevakallio
reviewed
Oct 19, 2017
src/util/start-server.js
Outdated
| assert.isNotSymlinked(packageLookup[key]); | ||
| if (assert.isSymlinked(packageLookup[key])) { | ||
| const packagePath = path.resolve(process.cwd(), 'node_modules', packageLookup[key]); | ||
| fs.removeSync(packageLookup[key]); |
There was a problem hiding this comment.
This should be packagePath?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will still create symlinks as part of
whack link <package_name>, which will break running the RN Packager directly.That shouldn't be too much of an issue though, as from there users should be doing
whack run start( / similar).Once the server is running, we
removeSyncany symlinks we encounter (so we don't break the RN Bundler), and pass that directory torsyncas before.