-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mouse movements bug #16
Comments
What terminal type are you using? |
Getting the same. I'm using iTerm2 in "Full-Width Top of Screen" ("guake") mode with zsh. My dev start script is |
Also experiencing the same issue with iTerm2. |
I'm having the same issue and my iTerm settings are the same as yours @kenwheeler |
I'm just using plain old terminal on mac @kenwheeler . I am using oh-my-zsh. Tried it on that as well as fish. both have the same issue. |
What's interesting for me is that the bug continues in iTerm2 after I kill the dev server as well. Could be related to chjj/blessed#235 FYI:
iTerm2: build 3.0.7 |
I've got the same issue with Termite on Arch Linux. |
@akre54 I can reproduce if I run with nodemon. Is everyone here running nodemon? |
Same, in Ubuntu 16.04.1 I don't think I'm running |
yeah you're using nodemon if you are using that kit. |
Ok, nodemon is the culprit. Issue filed here: remy/nodemon#890 , lets see what @remy has to say. Other suggestions certainly welcome. |
Yep we're using nodemon
|
It isn't just with nodemon though. Using babel-node without nodemon has the same issue. Both Terminal.app and iTerm2. Our app prints debugging info to the console (like queries run), so maybe it's an issue with piping stdout? |
I tried babel-node and couldn't reproduce the mouse issue. Maybe I'll just capture stdout and try to filter out control statements. |
@akre54 do you know of a way I can identify external stdout? |
Not that I'm aware of (short of running the script as a child proces). I'm going to give #27 a try, will let you know how that goes. |
That wont fix the nodemon issue. It'll work for child processes that use console, but for anything that uses stdout.write it'll still leak. Whats even stranger is, when using nodemon, if I exit, the server stays running. |
Right. I'm wondering if this is useful at all? https://github.com/remy/nodemon#pipe-output-to-somewhere-else |
Are you running nodemon using the node api? |
I pulled in #27 and it seems to be working to redirect my query logging to the log window (I had to reorder some stuff so that Dashboard was set up before anything got logged). So A+ on that. I'm still getting the mouse bug with nodemon and plain babel-node too. I'm running the nodemon executable (cli). I was thinking I could create an intermediate script that runs nodemon from the node-api. |
Same here as @brandonmp.
Express with |
Also getting this issue, I'll get my env details and pass along. |
Can you guys give this a shot #50 |
@kenwheeler unfortunately for my case, #50 did not resolve the issue. |
@eschaefer have you tried zsh instead of bash? |
@kenwheeler: just tried zsh (w/ iTerm2) too, and the problem is the same.
|
@eschaefer can I see your iterm settings page like i posted above? Also, how are you running the dashboard? Can i see a gist of your whole setup from package.json to your server/webpack config? |
Dashboard is being launched from an npm script (
bash script and webpack config file contents are in this gist |
Try the new approach in #50, look at the readme updates and use the webpack-dashboard bin in your npm scripts |
Fixes #890 Ref FormidableLabs/webpack-dashboard#16 The library blessed inside of the webpack-dashboard does some funky stuff with std streams and the expectation of the encoding. I'm not 100% sure of this change, I've got to see all the tests, but this tweak moves to inherit the child's stdin and doesn't purposely encode the stdin stream as utf8 (which, I don't recall exactly why I did this in the first place…though I'm fairly sure it was another issue somewhere else in nodemon).
@kenwheeler sorry, totally overlooked the readme updates... updated the gist. When I run this task alone, it's fine:
When I run the full bash script with a parallel server
|
what if you put the dashboard first |
I'm pretty confident that the PR I've raised against nodemon (expected to On Wed, 17 Aug 2016, 22:35 Eric Schaefer, notifications@github.com wrote:
|
This should be fixed in the latest release |
* fix: non-utf8 stdin processing Fixes #890 Ref FormidableLabs/webpack-dashboard#16 The library blessed inside of the webpack-dashboard does some funky stuff with std streams and the expectation of the encoding. I'm not 100% sure of this change, I've got to see all the tests, but this tweak moves to inherit the child's stdin and doesn't purposely encode the stdin stream as utf8 (which, I don't recall exactly why I did this in the first place…though I'm fairly sure it was another issue somewhere else in nodemon). * fix: use stdin:inherit when we're not forked * fix: don't use inherit when required * style: lint * style: I am going to 🐎 kick the lint in the 🌰
Fixes #894 Fixes #895 I'll have to continue investigation as to how we deal with spawned clients setting raw on stdin. Will break #890 and FormidableLabs/webpack-dashboard#16
This is back as I had to revert the change. It kinda blew up everyone's use of nodemon! I'll keep investigating. I know what the issue is, the child process is |
I'm still getting the characters printed on mouse events. Using the same environment as before, now with the new setup which runs the For your convenience:
|
Experiencing this issue on my system with the following details:
|
After updating |
Changing iterm2 'report terminal type' to ANSI stops the mouse movements bug. However, now I can't scroll :( |
I can confirm this. It is inconvenient, though. I'm running it on OSX 10.10.5 with iTerm2, settings identical to the ones recommended on this post. The project was bootstrapped from react-redux-starter-kit about six months ago. I've tried plugging in the dashboard via the recommended way (through the binary). This issue should probably be re-opened since the issue still persists. |
It happens when there are 2 or more processes active in one console thread. (Not sure if I call it properly) For example, in my
If I call |
Indeed, as @pietrasiak noticed, it happens when starting two processes in one thread. "scripts": {
"serve:dev": "webpack-dashboard -- webpack-dev-server --open --env dev & cd node_modules/api-mocks && DEBUG=-* yarn run start",
} Using a package like concurrently makes no difference (obviously). |
@flipflopsandrice you can run it standalone now, this should only happen using the old syntax where you pass a process. Otherwise it runs on its own and gets data via sockets. Doing it the old way, shown above, does some weird thing with stdout |
@kenwheeler Thanks, I fixed it by adding a separate npm script: "scripts": {
"dev:dashboard": "webpack-dashboard -- npm run serve:dev",
"serve:dev": "webpack-dev-server --open --env dev & cd node_modules/api-mocks && DEBUG=-* yarn run start",
} |
I get a strange behavior when I move my mouse around the terminal. I've tried this in fish and oh my zsh:

The text was updated successfully, but these errors were encountered: