This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Chore: Add --retries=NUM to builder run
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix args flags object. Add general help More help parsing / output. Refactor flags into first-class object. Add run --retries option. Also add builder run === builder help. Fixes #37 Add in retries for run. Remove local npm link stuff. NIT: remove newline
ryan-roemer
force-pushed
the
chore-retries
branch
from
38bdcd9 to
6ea064a
Compare
| retries: { | ||
| desc: "Number of times to re-run task on non-zero exit (default: `1`)", | ||
| types: [Number] | ||
| } |
There was a problem hiding this comment.
Slightly confusing: the wording makes me think the default is to try twice (1 initial attempt, 1 retry). But looking at the retry code I think the default is 1 attempt and no retries. IMO either this should be named --attempts with a default of 1, or have --retries default to 0 (add 1 to whatever number is given, for the initial attempt, or use doWhilst instead of whilst).
There was a problem hiding this comment.
@exogen -- How about --tries|attempts=1? or do you think --retries being 1 + NUM_RETRIES is more straightforward?
|
👍 |
ryan-roemer
added a commit
that referenced
this pull request
Dec 2, 2015
Chore: Add `--retries=NUM` to `builder run`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes #16
Fixes #37
noptbecause that's whatnpmuses and our mantra is "just likenpm" 😉builder run --retries=NUM TASKbuilder runtobuilder helpFeature:builder runshould list available scripts #37builder help runspecific help with specific flags--builderrc=PATHglobal command flag.builder installRemovebuilder installtask / functionality. #16My use case for this is retries for
requirepackfunctional tests (where I can't use magellan)./cc @chaseadamsio @boygirl @exogen