Display error message on UI download failed due to CORS not set prope…

…rly #217
Forceu · Dec 11, 2024 · df95205 · df95205
1 parent 575d4a6
commit df95205
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cmd/gokapi/Main.go b/cmd/gokapi/Main.go
@@ -135,7 +135,7 @@ func initCloudConfig(passedFlags flagparser.MainFlags) {
 		encLevel := configuration.Get().Encryption.Level
 		env := environment.New()
 		corsCheckDisabled := passedFlags.DisableCorsCheck || env.DisableCorsCheck
-		if !corsCheckDisabled && (encLevel == encryption.FullEncryptionStored || encLevel == encryption.FullEncryptionInput) {
+		if !corsCheckDisabled && (encLevel == encryption.FullEncryptionStored || encLevel == encryption.FullEncryptionInput || encLevel == encryption.EndToEndEncryption) {
 			ok, err := aws.IsCorsCorrectlySet(cConfig.Aws.Bucket, configuration.Get().ServerUrl)
 			if err != nil {
 				fmt.Println("Warning: Cannot check CORS settings. " + err.Error())

diff --git a/internal/webserver/web/templates/html_download.tmpl b/internal/webserver/web/templates/html_download.tmpl
@@ -113,7 +113,13 @@
 
 			pump();
 		    } catch (err) {
-			displayError(err);
+		        if (err.message.includes("Failed to fetch")) {
+		        	console.log(err);
+				displayError("Unable to download file. Please contact the uploader. Possible problem: Incorrect CORS rules, if using remote storage");
+
+		        } else {
+				displayError(err);
+		        }
 		    }
 		}