This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Move util database modification functions #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siikamiika
reviewed
May 5, 2020
There was a problem hiding this comment.
The descriptive error messages for stuff like importing a duplicate dictionary don't work:
Yomichan v20.4.18.0 has encountered a problem.
Originating URL: chrome-extension://jpjldhmgaijbpomlojkhkghbbebbiblb/bg/settings.html
Error
Issues can be reported at https://github.com/FooSoft/yomichan/issues
| @@ -809,6 +811,11 @@ class Backend { | |||
| return portName; | |||
| } | |||
|
|
|||
| async _onApiImportDictionaryArchive({archiveContent, details}, sender, onProgress) { | |||
| this._validatePrivilegedMessageSender(sender); | |||
There was a problem hiding this comment.
Should this be moved to the handler info object like in #497 (separately)?
There was a problem hiding this comment.
Probably, now that there's somewhat of a convention for it.
Error serialization problems caught me again. c062ef1 |
siikamiika
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apiImportDictionaryArchiveandapiDeleteDictionaryreplaceutilDatabaseImportandutilDatabaseDeleteDictionary.Related: #455