-
Notifications
You must be signed in to change notification settings - Fork 773
Carthage Support #74
Carthage Support #74
Conversation
Great! Just one thing, can you update the Readme with the cartage option and installation instructions? |
About the menu have you checked this https://github.com/cxa/MenuItemKit |
I will update the Readme tonight; I'll bring my computer home. re: MenuItemKit, I actually submitted a Carthage Support PR for that too, so we can use it with Carthage 😛 It shouldn't be hard to swap in. |
Okay, I updated the README and set Carthage to point to the original UIMenuItem. I also updated the Carthage scheme to deploy to 8.0 There is a problem right now, |
I had to restructure the directory structure a little bit, and tested both creating a new CocoaPods project and a new Carthage project with my fork.
I had to add a pair of compiler directives for
SSZipArchive
andUIMenuItem_CXAImageSupport
;SSZipArchive
drops the module prefix when installed through CarthageUIMenuItem_CXAImageSupport
doesn't seem to be the same between CocoaPods and Carthage so I changed the initializer depending on whether CocoaPods or Carthage is used.There is one final caveat: I had to add Carthage support to
UIMenuItem
andZFDragableModalTransition
, but my pull requests have not been accepted yet. When (if) they're accepted we'll need to update the FolioReader Cartfile to reference them instead of my forks (so we can keep getting upstream updates).That said, UIMenuItem is deprecated, so it may also be wise to update to the latest version of that (I added Carthage support to that one as well, also not merged yet).