Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cannot get it working #48

Closed
cornem opened this issue Sep 13, 2024 · 5 comments
Closed

Bug: Cannot get it working #48

cornem opened this issue Sep 13, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@cornem
Copy link

cornem commented Sep 13, 2024

Description

I'm trying to add your library to my Angular project, but I'm unable to get it to work. It fails to build.

Steps to Reproduce

version 12.6.1
If I add @foblex/flow (12.6.1) with @foblex/core (1.2.5) it fails to compile with errors (there are many):

./node_modules/@foblex/flow/fesm2022/foblex-flow.mjs:4512:67-85 
- Error: export 'WindowService' (imported as 'i3$1') was not found in '@foblex/core' (possible exports: Arc, BooleanExtensions, DomElementExtensions, EOperationSystem, EventExtensions, GuidExtensions, IDragAndDropBase, IMouseEvent, IPointerEvent, ITouchDownEvent, ITouchMoveEvent, ITouchUpEvent, Line, LineExtensions, MOUSE_EVENT_IGNORE_TIME, MouseEventExtensions, NumberExtensions, PlatformService, Point, PointExtensions, RectExtensions, SizeExtensions, TransformModelExtensions, VectorExtensions, defaultTransformModel, mixinChangePosition, mixinChangeZoom, mixinFitToParent, mixinOneToOneCentering, parseTransformModel, sanitizeElementId)

If I add @foblex/flow (12.6.1) with @foblex/core (1.2.3) it fails to compile with this errors (there are many):

Error: node_modules/@foblex/flow/f-backgroud/f-circle-pattern/f-circle-pattern.component.d.ts:31:96 
- Error TS2344: Type '{ id: { alias: "id"; required: false; }; color: { alias: "color"; required: false; }; radius: { alias: "radius"; required: false; }; }' does not satisfy the constraint '{ [key: string]: string; }'.
  Property '"id"' is incompatible with index signature.
    Type '{ alias: "id"; required: false; }' is not assignable to type 'string'.

Expected Result

A working app.

Actual Result

Compilation errors.

Environment Details

Angular v15

Screenshots or Videos

No response

Additional Context

No response

@cornem cornem added the bug Something isn't working label Sep 13, 2024
@siarheihuzarevich
Copy link
Member

@cornem Thank you for bringing this issue to our attention. We’ve identified and fixed the problem with the missing WindowService in @foblex/core. To resolve the error, please reinstall @foblex/f-flow in your project:

1.	Remove the existing @foblex/flow and @foblex/core packages from your node_modules directory and package.json.
2.	Run npm install @foblex/flow to install the latest version with the fix.

@cornem
Copy link
Author

cornem commented Sep 13, 2024

The latest version doesn't work for me either:

Error: node_modules/@foblex/flow/f-backgroud/f-circle-pattern/f-circle-pattern.component.d.ts:33:96 - error TS2344: Type '{ id: { alias: "id"; required: false; }; color: { alias: "color"; required: false; }; radius: { alias: "radius"; required: false; }; }' does not satisfy the constraint '{ [key: string]: string; }'.
  Property '"id"' is incompatible with index signature.
    Type '{ alias: "id"; required: false; }' is not assignable to type 'string'.

33     static ɵcmp: i0.ɵɵComponentDeclaration<FCirclePatternComponent, "f-circle-pattern", never, { "id": { "alias": "id"; "required": false; }; "color": { "alias": "color"; "required": false; }; "radius": { "alias": "radius"; "required": false; }; }, {}, never, never, false, never>;

Is this library compatible with Angular v15?

@siarheihuzarevich
Copy link
Member

Yes, it fully supports versions starting from 12. I will try to investigate your problem

@siarheihuzarevich
Copy link
Member

@cornem Yes, we found a bug, we will try to fix it today.

@siarheihuzarevich
Copy link
Member

@cornem Fixed. v12.6.3

  1. Remove the existing @foblex/flow and @foblex/core packages from your node_modules directory and package.json.
  2. Run npm install @foblex/flow to install the latest version with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants