Fix grad conv im2col #539
Merged
Fix grad conv im2col #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder how it is possible this path was never tested. Thank you for this quick fix! Can you add a test? |
|
I have enabled the tests marked broken that should've checked for this. Let's see if they pass now. |
This reverts commit d648fdd.
|
Hm those fail for other reasons it seems, added an explicit distinct test. |
wsmoses
force-pushed
the
grad_conv_im2col
branch
from
035be0a
to
9215fa9
Compare
wsmoses
force-pushed
the
grad_conv_im2col
branch
from
9215fa9
to
9fdc328
Compare
ToucheSir
reviewed
Sep 26, 2023
ToucheSir
approved these changes
Sep 27, 2023
|
nope, am all done, go for it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538
Required for #536