Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change libblas to libblastrampoline #396

Merged
merged 11 commits into from
Mar 4, 2022
Merged

Change libblas to libblastrampoline #396

merged 11 commits into from
Mar 4, 2022

Conversation

theabhirath
Copy link
Member

@theabhirath theabhirath commented Mar 2, 2022

Xref JuliaLang/julia#44360, libblas is not used anymore for Julia v1.9 and above, and libblastrampoline is instead. Causing errors for CI on Julia master including places like FluxML/Metalhead.jl#125 (comment)

@theabhirath theabhirath changed the title Changed libblas to libblastrampoline Change libblas to libblastrampoline Mar 2, 2022
src/gemm.jl Outdated Show resolved Hide resolved
src/gemm.jl Outdated Show resolved Hide resolved
@IanButterworth
Copy link
Contributor

@ViralBShah what's the right thing to do here?

theabhirath and others added 2 commits March 3, 2022 22:38
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
@ViralBShah
Copy link
Member

You can use Base.libblas_name (merged last night in a follow-on PR) which now points to libblastrampoline. That will work with 1.6 as well as older releases.

@IanButterworth
Copy link
Contributor

Seems like there's an exported name clash? or is libblas imported in another file?

@ViralBShah
Copy link
Member

ViralBShah commented Mar 3, 2022

We need a new Julia nightly to come out today that should make this work. It works locally for me on julia master.

@ViralBShah
Copy link
Member

Linux nightly binaries are unfortunately a bit behind - and we'll have them shortly. This should fix the issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants